| Title | Bugzilla fixes table shows the fixer, not the changer |
| Status | closed |
| Priority | essential |
| Assigned user | Nick Barnes |
| Organization | Ravenbrook |
| Description | The patched Bugzilla bug form has a fixes table showing Perforce fixes for the bug. The table has one row per fix record, showing the changelist number, date, description, and user. The "user" column shows the user who made the fix record, not the user who made the change. This is counter-intuitive, not very useful, and contrary to the P4DTI documentation, in particular the IG [1]. |
| Analysis | In bug_form.pl, the SQL join used for this table has an incorrect condition. Instead of "AND profiles.userid = p4dti_fixes.user", it should say "AND profiles.userid = p4dti_changelists.user". |
| How found | manual_test |
| Evidence | [1] <http://www.ravenbrook.com/project/p4dti/release/1.5.3/ig/#section-10> |
| Observed in | 1.5.3 |
| Introduced in | 0.5.0 |
| Created by | Nick Barnes |
| Created on | 2003-05-30 15:39:16 |
| Last modified by | Nick Barnes |
| Last modified on | 2003-10-22 13:41:40 |
| History | 2003-05-30 NB Created. |
| Change | Effect | Date | User | Description |
|---|---|---|---|---|
| 61290 | closed | 2003-10-22 13:41:31 | Nick Barnes | When reporting a fix, should ascribe it to the changelist's user, not the fix record's user (job000704). |