P4DTI issue job000304

TitleIf replication fails, reverting may also fail
Statusclosed
Priorityessential
Assigned userNick Barnes
OrganizationRavenbrook
DescriptionIf the replicator fails to replicate changes from a P4 job to a DT issue, it tries to revert the P4 job with the DT issue (and sends an error email). Under some circumstances, this attempt to revert the P4 job may also fail, due to a failure to log the replication failure correctly. This bug is rather hard to diagnose because the resulting emailed error message is reporting two (actually three, see job000303) nested errors.
Analysisreplicator.overwrite_issue_dt_to_p4 takes an argument called 'reason' which must be a list of catalog messages. These messages are going to go in the log and also in an emailed error message. replicator.revert_issue_dt_to_p4 calls this function with reason set to a list containing a catalog message (851) and an exc_value. Trying to log the exc_value breaks the catalog (see job000303). Possibly we should make the exc_value an argument to message 851 instead. NB 2001-04-20.
How foundcustomer
Evidence<URL: http://info.ravenbrook.com/mail/2001/04/20/12-36-53/0.txt>
Observed in1.1.1
Introduced in0.4.0
Created byNick Barnes
Created on2001-04-20 15:50:10
Last modified byGareth Rees
Last modified on2001-12-10 19:40:18
History2001-04-20 NB Created.

Fixes

Change Effect Date User Description
13278 closed 2001-06-14 15:13:26 Gareth Rees The reason argument to overwrite_issue_dt_to_p4 must consist only of messages, since they are logged as well as mailed.