Title | Bugzilla: Can't use Perforce to confirm an unconfirmed bug |
Status | closed |
Priority | essential |
Assigned user | Nick Barnes |
Organization | Ravenbrook |
Description | An unconfirmed Bugzilla bug can not be confirmed from Perforce. That is, a bug status "UNCONFIRMED" can not be changed by editing the corresponding Perforce job. Attempting to confirm a bug will cause a replication failure, with a message like "Given 1 when expecting a string". |
Analysis | The integration is smart enough to know that it should set the 'everconfirmed' field to 1 when confirming a bug, but not smart enough to know that 'everconfirmed' is a number. So in bugzilla.py, when quoting the value 1 to update the bug record, we give 1 to sqlquote, and get a failure: "Given 1 when expecting a string." Add this to the 'bugs' entry in quote_table in bugzilla.py: 'everconfirmed': self_str, 'groupset': self_str, 'reporter': self_str, 'qa_contact': self_str, 'votes': self_str (note that some of these are read-only from Perforce, but if we add them to this table now then they will work if we ever allow the replicator to update them). |
How found | manual_test |
Evidence | email backtrace. |
Observed in | 1.0.4 |
Introduced in | 0.5.0 |
Test procedure | <http://www.ravenbrook.com/project/p4dti/master/test/test_p4dti.py >, section 14 |
Created by | Nick Barnes |
Created on | 2001-03-20 15:07:20 |
Last modified by | Gareth Rees |
Last modified on | 2010-10-07 12:06:09 |
History | 2001-03-20 NB Created. 2001-03-21 NB Changed description to user visible impact. 2001-03-21 RB Set priority to essential. |
Change | Effect | Date | User | Description |
---|---|---|---|---|
22404 | closed | 2001-09-10 15:49:37 | Nick Barnes | Quote values of integral types correctly when constructing SQL. job000262 |
12440 | closed | 2001-05-09 14:33:51 | Nick Barnes | Adding bugs to Bugzilla now seems to work. |