| Title | No smoke test coverage of mapping failure in pagesMarkAllocated |
| Status | open |
| Priority | nice |
| Assigned user | Gareth Rees |
| Organization | Ravenbrook |
| Description | In the VM arena class, pagesMarkAllocated has a failure case with a TODO: /* region from basePI to j needs deallocating */ /* TODO: Consider making pages spare instead, then purging. */ Before implementing the TODO, we'd like to be confident that this code is exercised by a test case. But the smoke tests passes even if this block of code is replaced with NOTREACHED. |
| Analysis | This is because the smoke test cases don't set a commit limit. There used to be a commit limit test in amcss and a couple of other tests, but it was removed in change 189781 [2]. |
| How found | inspection |
| Evidence | [1] https://info.ravenbrook.com/mail/2018/08/01/11-04-05/0/[2] https://info.ravenbrook.com/infosys/cgi/perfbrowse.cgi?@describe+189781 |
| Created by | Gareth Rees |
| Created on | 2018-08-01 11:42:07 |
| Last modified by | Gareth Rees |
| Last modified on | 2018-08-01 12:15:07 |
| History | 2018-08-01 GDR Created. |