| Title | No test cases for bogus arguments to mps_finalize |
| Status | closed |
| Priority | nice |
| Assigned user | Gareth Rees |
| Organization | Ravenbrook |
| Description | It is an error to attempt to register an address for finalization if [1]: 1. the address is not managed by the specified arena 2. the address is in a manually managed pool Similarly, it is an error to attempt to deregister an address if: 3. the address is not managed by the specified arena 4. no address has previously been registered for finalization 5. the address was not previously registered for finalization But there are no test cases checking for these errors. |
| Analysis | Errors 1, 2 and 3 cause assertions, so need MMQA tests in test/argerr. But errors 4 and 5 cause MPS_RES_FAIL to be returned, so could be tested in code/finalcv.c. |
| How found | inspection |
| Evidence | [1] https://www.ravenbrook.com/project/mps.../topic/finalization.html#c.mps_finalize |
| Created by | Gareth Rees |
| Created on | 2018-06-21 20:34:44 |
| Last modified by | Gareth Rees |
| Last modified on | 2018-06-26 09:02:33 |
| History | 2018-06-21 GDR Created. |
| Change | Effect | Date | User | Description |
|---|---|---|---|---|
| 194166 | closed | 2018-06-26 09:01:46 | Gareth Rees | Test cases for errors in finalization. |