| Title | MPS doesn't notice if clients write scanners that don't check error codes |
| Status | open |
| Priority | nice |
| Assigned user | Richard Brooksby |
| Organization | Ravenbrook |
| Description | If the client writes a scanner that ignores the result code of MPS_FIX2 then the MPS might not detect low memory conditions properly and cause crashes in rare circumstances. |
| Analysis | We could store a result code in the ScanStateStruct and check it at the end of the scan. We could skip fixes if it is set. We could occasionally deliberately return secret codes to abort the scan and (a) check it was aborted and (b) restart the (supposedly idempotent) scan. |
| How found | inspection |
| Evidence | <https://github.com/drmeister/clasp/com...59acb8c6d53fb994#commitcomment-16765873> |
| Created by | Richard Brooksby |
| Created on | 2016-03-18 17:31:52 |
| Last modified by | Gareth Rees |
| Last modified on | 2018-06-27 13:05:13 |
| History | 2016-03-18 RB Created. |