| Title | Unnamed constants in arenaShouldCollectWorld |
| Status | closed |
| Priority | nice |
| Assigned user | Gareth Rees |
| Organization | Ravenbrook |
| Description | arenaShouldCollectWorld [1] has six unnamed constants: if (arenaSize > 1000000) { if ((arena->tracedSize > 1000000.0) && (arena->tracedTime > 1.0)) scanRate = 25000000.0; /* a reasonable default. */ arenaScanTime += 0.1; /* for overheads. */ sinceLastWorldCollect > arenaScanTime * 10.0) { |
| Analysis | These need names and moving to config.h. |
| How found | inspection |
| Evidence | [1] http://www.ravenbrook.com/project/mps/master/code/global.c#line-762 |
| Created by | Gareth Rees |
| Created on | 2015-08-21 14:31:58 |
| Last modified by | Gareth Rees |
| Last modified on | 2015-08-21 15:27:14 |
| History | 2015-08-21 GDR Created. |
| Change | Effect | Date | User | Description |
|---|---|---|---|---|
| 188160 | closed | 2015-08-21 15:27:14 | Gareth Rees | New function PolicyCollectionTime estimates the time needed to collect the arena. Mysterious constants are given names and moved to config.h. |