Title | commpre/commpost distinction is unnecessary |
Status | open |
Priority | nice |
Assigned user | Gareth Rees |
Organization | Ravenbrook |
Description | The Windows makefile system uses two common makefiles which are included around the compiler makefile, for example: !INCLUDE commpre.nmk !INCLUDE mv.nmk !INCLUDE commpost.nmk |
Analysis | But this is unnecessary after job003713 was fixed. We could merge them into a single comm.nmk. Backed out the first solution < https://info.ravenbrook.com/mail/2016/02/16/17-49-36/0/ >. There may be a way to do this using the same trick as you applied in changelist 187299 using a temporary makefile, or by naming variables different, e.g. mv.nmk could define CFLAGSTOOLPRE (because "mv" is a "tool"). RB 2016-02-16 |
How found | inspection |
Evidence | None |
Created by | Gareth Rees |
Created on | 2014-11-08 09:19:30 |
Last modified by | Richard Brooksby |
Last modified on | 2016-02-16 17:50:57 |
History | 2014-11-08 GDR Created. |
Change | Effect | Date | User | Description |
---|---|---|---|---|
189253 | open | 2016-02-16 17:46:27 | Richard Brooksby | Backing out changelist 187528 as it removed most of the flags from the C compiler command line on Windows. |
187528 | closed | 2014-11-29 16:43:45 | Gareth Rees | Merge commpre.nmk and commpost.nmk into comm.nmk. |