| Title | RASH variety does not compile |
| Status | closed |
| Priority | essential |
| Assigned user | Gareth Rees |
| Organization | Ravenbrook |
| Description | $ xcodebuild -config RASH In file included from mps.c:33: mpsi.c:68:13: error: 'static' function 'mpsi_check' declared in header file should be declared 'static inline' [-Werror,-Wunneeded-internal-declaration] static Bool mpsi_check(void) |
| Analysis | Clang emits this warning for functions that are declared static in a header but never called. We could avoid this warning by: 1. Turning off the warning: -Wno-unneeded-internal-declaration 2. Declaring these functions extern instead of static 3. Declaring these functions inline (but that won't help for functions not declared in header files). 4. Declaring these function __attribute__((__unused__)) |
| How found | manual_test |
| Evidence | None |
| Created by | Gareth Rees |
| Created on | 2014-05-01 11:23:23 |
| Last modified by | Gareth Rees |
| Last modified on | 2014-05-01 12:21:51 |
| History | 2014-05-01 GDR Created. |
| Change | Effect | Date | User | Description |
|---|---|---|---|---|
| 185915 | closed | 2014-05-01 12:18:00 | Gareth Rees | Fix RASH build on OS X by adding the unused attribute to functions declared static that are not called in the RASH variety. |