Title | ALIGN and ALIGN_UP macros are poorly named |
Status | closed |
Priority | nice |
Assigned user | Gareth Rees |
Organization | Ravenbrook |
Description | Christan Schafmeister reported in IRC that "I only found one error in the docs so far. In the Scheme example - obj_pad function - change ALIGN to ALIGN_UP" |
Analysis | These macros are poorly named, making it hard to remember what they do, and therefore hard to check that the right one has been used. ALIGN_UP rounds a size up to the next multiple of the machine word size. ALIGN does the same, but in addition makes sure that the returned size is big enough to store a forwarding pointer. Maybe ALIGN_WORD and ALIGN_OBJ? Any better suggestion? |
How found | customer |
Evidence | IRC #memorypoolsystem 2013-08-12 15:22 |
Observed in | 1.111.0 |
Introduced in | 1.111.0 |
Created by | Gareth Rees |
Created on | 2013-08-12 15:32:02 |
Last modified by | Gareth Rees |
Last modified on | 2013-09-05 08:15:56 |
History | 2013-08-12 GDR Created. |
Change | Effect | Date | User | Description |
---|---|---|---|---|
183392 | closed | 2013-09-05 08:15:56 | Gareth Rees | Rename ALIGN_UP and ALIGN macros in the Scheme example as ALIGN_WORD and ALIGN_OBJ respectively. |