| Title | eventcnv output has bogus timestamp on totals row in CSV format |
| Status | closed |
| Priority | optional |
| Assigned user | Gareth Rees |
| Organization | Ravenbrook |
| Description | If you run eventcnv with the options -e (event statistics), -b (bucket size) and -SC (output in CSV format), then the last row has a bogus timestamp instead of some kind of total indication (like "run" in -S and "t" in -SL). |
| Analysis | Here's the offending code, which hints that there was some kind of design intention in printing the bogus timestamp: case 'C': { /* FIXME: This attempted to print the event stats on a row that resembled a kind of final event, but the event clock no longer runs monotonically upwards. */ EventClock last = eventTime + 1; EVENT_CLOCK_PRINT(stdout, last); } I can't figure out what the design intention was, so I don't propose to touch this code. |
| How found | manual_test |
| Evidence | Here's an example run. Note the bogus timestamp at the start of the last row. $ eventcnv -e all -b 1000000000 -SC 000000003B9AC9FF, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 000007DC7DC16553803, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 100, 18, 65, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 100, 100, 100, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 483 000007DC7DC16553804, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 100, 18, 65, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 100, 100, 100, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 483 |
| Observed in | 1.110.0 |
| Created by | Gareth Rees |
| Created on | 2012-10-21 16:04:15 |
| Last modified by | Gareth Rees |
| Last modified on | 2012-10-23 14:28:22 |
| History | 2012-10-21 GDR Created. |
| Change | Effect | Date | User | Description |
|---|---|---|---|---|
| 180028 | closed | 2012-10-23 14:28:22 | Gareth Rees | Remove reporting features from eventcnv, as discussed with RB. Eventcnv was always intended to be a simple tool that just translates events, not a report generator. In particular: * Remove -e option and associated event specification parsing. * Remove -b option and bucket statistics. * Don't intern labels (always print addresses). * Remove -v option (events are always output). * If -h or -? is specified, exit after printing help message. * Help text refer to the "Telemetry" section of reference manual. |