| Title | Possible improvement to reserve/commit protocol |
| Status | open |
| Priority | nice |
| Assigned user | Richard Brooksby |
| Organization | Ravenbrook |
| Description | It might be possible to omit the call to mps_ap_trip in mps_commit, and just go round the loop and let mps_ap_fill deal with it. This would reduce the size of compiled code with inline allocation. |
| Analysis | See e-mail thread [1] [2] [3] [4] [5] [6] [7] [8]. Note that this seems to rely on the client progam calling reserve and commit in a loop: if it just calls commit once, and does something else if it fails (rather than going round the loop), then it isn't obvious that this will work. (But maybe it will be OK because the next call to reserve on the same AP will handle the trip, regardless of when that happens.) |
| How found | inspection |
| Evidence | [1] <http://info.ravenbrook.com/mail/2012/10/19/12-51-13/0/>[2] < http://info.ravenbrook.com/mail/2012/10/19/12-53-54/0/>[3] < http://info.ravenbrook.com/mail/2012/10/19/13-32-05/0/>[4] < https://info.ravenbrook.com/mail/2012/10/19/13-38-06/0/>[5] < https://info.ravenbrook.com/mail/2012/10/19/13-39-12/0/>[6] < https://info.ravenbrook.com/mail/2012/10/19/13-42-02/0/>[7] < https://info.ravenbrook.com/mail/2012/10/19/14-25-50/0/>[8] < https://info.ravenbrook.com/mail/2012/10/22/12-16-57/0/> |
| Observed in | 1.110.0 |
| Created by | Gareth Rees |
| Created on | 2012-10-19 14:36:04 |
| Last modified by | Gareth Rees |
| Last modified on | 2013-11-04 13:28:25 |
| History | 2012-10-19 GDR Created. |