| Title | MPS build failure on Linux with glibc 2.3: wrong defines before system includes |
| Status | closed |
| Priority | essential |
| Assigned user | Richard Kistruck |
| Organization | Ravenbrook |
| Description | MPS build failure on Linux with glibc 2.3: wrong defines before system includes RHSK 2006-05-19 code/prmcli.h#8 and code/pthrdext.c#9 don't build on modern linuxen. Build failure looks like this: [ Not yet known -- please describe it here. RHSK 2006-05-19 ] prmcli.h and pthrdext.c have: /* open sesame magic */ #define _BSD_SOURCE 1 #define _POSIX_C_SOURCE 1 Andreas [Bogk in IM 2006-02-08] reports that this needs to be: #define _GNU_SOURCE 1 For details, see OpenDylan's CVS [Bogk dylan cvs 2005-09-24]: < http://www.opendylan.org/cvszilla/transaction.cgi?id=9972>DRJ 2007-03-12 Possibly duplicated by job001637 and fixed by change 161907. |
| Analysis | RHSK 2006-05-19 Note: what does "open sesame magic" mean? DRJ has been caught using the term :-) < http://info.ravenbrook.com/mail/2006/05/19/08-30-57/0.txt>["open sesame magic" means the tricks you need to perform in order to get a system header file, such as <signal.h>, to declare the prototypes and/or structs (etc) that you need to use. Generally you need to #define something before including a system header file in order to get fully approved standard interfaces. This is how different standards (and different versions of the same standards) all manage to share the same header files. See [XSHCE] for example. DRJ 2007-03-12] DRJ 2007-03-12 Damn, wish I'd seen this before making job001637 and change 161907. Which as far as I can tell describe exactly the same problem. In that change I fixed it with #define _XOPEN_SOURCE 500 |
| How found | unknown |
| Evidence | [Bogk dylan cvs 2005-09-24] <http://www.opendylan.org/cvszilla/transaction.cgi?id=9972>[Bogk in IM 2006-02-08] <file://duck.ravenbrook.com/Users/richardk/Library/Application%20Support/Adium%202.0/Users/Default/Logs/AIM.rhskravenbrook/193882992/193882992%20(2006-02-08).html> [XSHCE] http://opengroup.org/onlinepubs/007908799/xsh/compilation.html |
| Observed in | 1.106.1 |
| Created by | Richard Kistruck |
| Created on | 2006-05-19 12:46:24 |
| Last modified by | Richard Brooksby |
| Last modified on | 2012-09-21 20:44:47 |
| History | 2006-05-19 RHSK Created. 2006-05-19 RHSK Correct URL for IM chat (even though no-one but me can use it) 2007-03-12 DRJ Duplicate and fix and open sesame. |
| Change | Effect | Date | User | Description |
|---|---|---|---|---|
| 178816 | closed | 2012-08-02 13:05:51 | Richard Brooksby | Merging branch/2012-07-26/linux-catchup. |